-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[CXP-2151] Updates to Processes and Containers documentation #29409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
``` | ||
|
||
Then, upgrade your Helm chart. | ||
|
||
In some setups, the Process Agent and Cluster Agent cannot automatically detect a Kubernetes cluster name. If this happens, the feature does not start, and the following warning displays in the Cluster Agent log: `Orchestrator explorer enabled but no cluster name set: disabling.` In this case, you must set `datadog.clusterName` to your cluster name in `values.yaml`. | ||
In some setups, the Cluster Agent cannot automatically detect a Kubernetes cluster name. If this happens, the feature does not start, and the following warning displays in the Cluster Agent log: `Orchestrator explorer enabled but no cluster name set: disabling.` In this case, you must set `datadog.clusterName` to your cluster name in `values.yaml`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove mention of dedicated process agent as container collection functionality no longer runs in process agent by default
@@ -226,7 +229,7 @@ You can see indexed logs that you have chosen to index and persist by selecting | |||
|
|||
{{< img src="infrastructure/livecontainers/errorlogs.png" alt="Preview Logs Side panel" style="width:100%;">}} | |||
|
|||
## Notes and known issues | |||
## Additional information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither of these seem like issues, so updating the section title to match the one on the Processes page: https://docs.datadoghq.com/infrastructure/process/?tab=linuxwindows#additional-information
@@ -207,7 +207,7 @@ For more information about installing the Datadog Agent with AWS ECS Fargate, se | |||
|
|||
### I/O stats | |||
|
|||
I/O and open files stats can be collected by the Datadog system-probe, which runs with elevated privileges. To enable the process module of the system-probe, use the following configuration: | |||
I/O and open files stats can be collected by the Datadog system-probe, which runs with elevated privileges. To collect these stats, use the following configuration to enable the process module of the system-probe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some clarification here that enabling the process module enables I/O stats collection, as otherwise it seemed a bit disjointed
@@ -39,11 +39,11 @@ You can generate a new process-based metric directly from queries in the [**Live | |||
|
|||
{{< img src="infrastructure/process/process2metrics_create.png" alt="Create a process-based metric" style="width:80%;">}} | |||
|
|||
1. **Select tags to filter your query**: The query syntax is the same as for [Live Processes][2]. Only processes matching the scope of your filters are considered for aggregation. Text search filters are supported only on the Live Processes page. | |||
1. **Select tags to filter your query**: The available tags are the same as for [Live Processes][2]. Only processes matching the scope of your filters are considered for aggregation. Text search filters are supported only on the Live Processes page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query syntax is not the same. Boolean operators are not supported here, unlike in the Processes page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits! Let me know when ready for final review/approval :)
@@ -491,7 +494,7 @@ You can customize integration views (for example, when aggregating a query for N | |||
|
|||
## Processes across the platform | |||
|
|||
### Live containers | |||
### Live Containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original was actually correct - we follow sentence casing for headers!
### Live Containers | |
### Live Containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: domalessi <[email protected]>
live containers back to upper case
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
What does this PR do? What is the motivation?
Changes in this PR include:
DD_PROCESS_AGENT_ENABLED
config, replacing with new configs.Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes